Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ML] [AIOps] Fixing log pattern analysis test #172854

Merged
merged 13 commits into from
Dec 19, 2023
Merged

[ML] [AIOps] Fixing log pattern analysis test #172854

merged 13 commits into from
Dec 19, 2023

Conversation

jgowdyelastic
Copy link
Member

@jgowdyelastic jgowdyelastic commented Dec 7, 2023 •
edited
Loading

Fixes #172739 and #172770 which I believe are caused by the random sampler's selection of docs which caused the pattern analysis to find 4 categories rather than 3.
This change ensures random sampling is switched off before running the analysis.

@jgowdyelastic jgowdyelastic self-assigned this Dec 7, 2023
@jgowdyelastic jgowdyelastic added non-issue Indicates to automation that a pull request should not appear in the release notes :ml release_note:skip Skip the PR/issue when compiling release notes Feature:ML/AIOps ML AIOps features: Change Point Detection, Log Pattern Analysis, Log Rate Analysis v8.12.0 labels Dec 7, 2023
@jgowdyelastic jgowdyelastic marked this pull request as ready for review December 7, 2023 16:48
@elasticmachine
Copy link
Contributor

Pinging @elastic/ml-ui (:ml)

peteharverson
peteharverson approved these changes Dec 7, 2023
View reviewed changes
Copy link
Contributor

@peteharverson peteharverson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code LGTM

@jgowdyelastic jgowdyelastic mentioned this pull request Dec 8, 2023
Closed
alvarezmelissa87
alvarezmelissa87 approved these changes Dec 18, 2023
View reviewed changes
Copy link
Contributor

@alvarezmelissa87 alvarezmelissa87 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM ⚡

@kibana-ci
Copy link
Collaborator

💛 Build succeeded, but was flaky

Failed CI Steps

Metrics [docs]

✅ unchanged

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

cc @jgowdyelastic

@jgowdyelastic jgowdyelastic merged commit f004e87 into elastic:main Dec 19, 2023
37 checks passed
@kibanamachine kibanamachine added the backport:skip This commit does not require backporting label Dec 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@peteharverson peteharverson peteharverson approved these changes

@alvarezmelissa87 alvarezmelissa87 alvarezmelissa87 approved these changes

@walterra walterra Awaiting requested review from walterra

Assignees

@jgowdyelastic jgowdyelastic

Labels
backport:skip This commit does not require backporting Feature:ML/AIOps ML AIOps features: Change Point Detection, Log Pattern Analysis, Log Rate Analysis :ml non-issue Indicates to automation that a pull request should not appear in the release notes release_note:skip Skip the PR/issue when compiling release notes v8.13.0
Projects
None yet
Milestone
No milestone
6 participants
@jgowdyelastic @elasticmachine @kibana-ci @alvarezmelissa87 @peteharverson @kibanamachine